Open jbilcke-hf opened 2 months ago
partially done, I've added:
However, the BPM isn't fully connected to the timeline grid yet (changing it won't change the alignment of segments yet)
and yes, later we can have BPM per-segment (with segments acting as groups)
Context
If we want to support music videos, we need at least a basic support of BPM (beats per minute)
this will help us product a nice grid alignment
Solution
Notes
If you search for BPM in the code base, you will see there are already function to detect that.
Note that to work as expected, we will need to make the duration per step variable.
Initially we were using this:
But I've just pushed a PR to move this to
durationInMsPerStep
inside theuseTimeline
this is still static, but at least now we have a way to mutate the value of
durationInMsPerStep
based on the detected BPM