search

jbinkley60 / plugin.program.kscleaner

GNU General Public License v2.0
9 stars 2 forks source link

Support Kodi Profiles #3

Closed bossanova808 closed 8 months ago

bossanova808 commented 10 months ago

(as the backup functionality doesn't seem to operate yet, that part is untested)

I've just started having a play with this addon.

Using the 1.0.4 zip posted in the forum (although is branch is 1.03g so not quite sure what's going on there).

I immediately got errors because you were using special://userdata (which is just an alias Alias from special://masterprofile (https://kodi.wiki/view/Special_protocol)

This should instead be special://profile which copes with both folks just using the default masterprofile, and those of us using separate profiles for separate users.

I also changed a line in backup.py which I think is correct, but can't be sure as when I try to run a DB backup it tells me 'functionality not available yet' or similar.

This should be enough to get you on the right track for proper profile support, anyway!

(Also I could not see the 'clean all tables' option mention for 1.0.4?)

jbinkley60 commented 10 months ago

Thanks for the PR request. I may merge it or add it into the next release which has a few other advancedsettings.xml parsing improvements. The profiles change for advanced setting should be fine. You still get the error on backups because it doesn't support My SQL backups, just local SQlite. The presumption is if folks are advanced enough to run a SQL database server they typically have separate DBA practices and similar for backups. Thus file level backups are currently only supported for local Kodi databases.

bossanova808 commented 9 months ago

Yes sure, use it as you will, it's a very minor but handy change.

You might want to improve the message re the database back-ups maybe, then, to make that clearer it's MySQL related in this context - but you're right, those using MySQL will likely have an established backup process (as I indeed do).

jbinkley60 commented 9 months ago

Thanks for the feedback. I'll work on improving the messaging. I hope to have a test release with some enhancements by the end of next week. I had already caught the database 124 numbering in 1.0.4 but since I forgot to post the code till yesterday you couldn't see it unless you installed the 1.0.4 release package.

bossanova808 commented 8 months ago

Will close as this is now in anyway

jbinkley60 commented 8 months ago

Thanks for closing.