jbirnick / polybar-timer

A simple & customizable timer for your bar.
MIT License
61 stars 6 forks source link

Scroll up not working without dunstify #3

Closed thomas-forbes closed 6 days ago

thomas-forbes commented 2 years ago

When you don't have dunstify installed the scroll up functionality described in the readme doesn't work. This is because when you ./polybar-timer.sh increase 60 you get ./polybar-timer.sh: line 20: dunstify: command not found and an error which means it will create a new timer overwriting the increase.

jbirnick commented 2 years ago

Yes. That is also more or less mentioned in the README:

Inside the script dunstify is called to view the mentioned notification for the expiry time. But this is not necessary. (Just beautiful.) If you do not use Dunst then still everything (but the preview of the expiry time) will work fine without dependencies.

In that case you would have to edit the script yourself. I want to keep it as simple as possible, so I'm not going to introduce a config or anything.

For example you can modify the printExpiryTime and deleteExpiryTime functions so that they do nothing:

printExpiryTime () { :; }
deleteExpiryTime () { :; }

I will also add a link to this to the README, thank you.

jbirnick commented 2 years ago

Since the newest update it's 3 lines you have to edit:

printExpiryTime () { :; }
printPaused () { :; }
removePrinting () { :; }
CNote1 commented 2 years ago

I've got syntax error after editing these lines.

jbirnick commented 2 years ago

Thanks, I've edited it. Now it should work.

raffaem commented 7 months ago

Why not use notify-send?

jbirnick commented 7 months ago

Look at this screen recording:

expiryTimePreview

The notification is updated when you scroll. This is not possible with notify-send. With notify-send you could only spam new notifications, and then you suddenly have 50 notifications on your desktop.

EDIT: Oh wait, it seems like notify-send can do this nowadays?! Then I might replace this soon.

jbirnick commented 6 days ago

Now it only uses notify-send.