search

jbisanz / qiime2R

Import qiime2 artifacts to R
MIT License
156 stars 53 forks source link

Support for DataLoafPackageDirFmt format to import ANCOM-BC results QZA files #68

Open SergioAlias opened 4 months ago

SergioAlias commented 4 months ago

Hello, thank you so much for the qiime2r package. I recently tried to import my ANCOM-BC results (output of qiime composition ancombc) but it seems that its format (DataLoafPackageDirFmt) is not supported by read_qza.

Looking at the code I think I might try to add it myself, but since that would be my first time submitting a PR to someone else's repo I want to ensure that I follow the correct process and adhere to your projects contributing guidelines. I couldn't find any Contributing section in the README, so I would like to know if it's okay if I just fork the repo, work on it, and then do a PR and remove my fork. If you prefer to add the functionality yourself, that's fine with me too.

IrshadUlHaq1 commented 3 months ago

@SergioAlias Were you able to solve this problem? Just curious to know before I run into it when I analyze my data in the nearest future.

SergioAlias commented 3 months ago

@IrshadUlHaq1 I opened a PR addressing this. In the meantime, you can read ANCOM-BC results in R using any CSV package.