jbjorne / TEES

Turku Event Extraction System
147 stars 44 forks source link

"unexpected keyword argument" in ConvertXML.py #16

Closed fmatthies closed 8 years ago

fmatthies commented 9 years ago

I stumbled over this: the arguments to "STTools.loadSet()" In line 566 & 572 of "Utils/STFormat/ConvertXML.py" are wrong; namely "a2Tag" has to be "a2Tags".

Best, Franz

jbjorne commented 9 years ago

Dear Franz,

The argument should be correct now. I also added to ConvertXML.py a new command line parameter 'inputTags' that can be used to define the a2-file extensions for 'STTools.loadSet()'. Hope this works!

Best Regards, Jari

fmatthies commented 9 years ago

Dear Jari, That was swift and the additional parameter is helpful, thanks! Another issue I stumbled upon: the same arguments mentioned above have as default a 'string' value, but STTools.load() assumes a list value only ("for a2Tag in asTags" -- line 60). For my local code I inserted a differentiation to deal with string values as well.

All the best, Franz

jbjorne commented 9 years ago

I'm sorry, which arguments have the default value as a string? At least 'STTools.loadSet()' has a list (["a2", "rel"]) as the default a2Tags-value, and so does 'Document.load()'?

fmatthies commented 9 years ago

Oh sorry, it was again in line 566 & 572 of the former "Utils/STFormat/ConvertXML.py". (I didn't use your updated version) With the additional line "options.inputTags = options.inputTags.split(",")" (line 559) it should work now as intended. Thanks again.