jbkinney / logomaker

Software for the visualization of sequence-function relationships
MIT License
179 stars 34 forks source link

hydrophobicity color_theme #39

Closed TangYiChing closed 2 months ago

TangYiChing commented 2 months ago

Hi,

Can you clarify how hydrophobicity is defined and the color coding for hydrophobic, hydrophilic, and neutral, respectively

jbkinney commented 2 months ago

These are just meant to be the standard physical property classifications of amino acids; we’re not working off of a specific rigorous definition. Do you see an error?

Cheers, -Justin

Justin B. Kinney, PhD
Associate Professor
Simons Center for Quantitative Biology
Cold Spring Harbor Laboratory
***@***.***
631-897-5731

On Aug 12, 2024, at 12:43 PM, Yi-Ching Tang @.***> wrote:

External email.


Hi,

Can you clarify how hydrophobicity is defined and the color coding for hydrophobic, hydrophilic, and neutral, respectively

— Reply to this email directly, view it on GitHubhttps://github.com/jbkinney/logomaker/issues/39, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXOC3GF6KVCTY2YLJTL633ZRDQ4BAVCNFSM6AAAAABMMRKXM6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DCNBWGI3DCOA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Disclaimer

The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.

TangYiChing commented 2 months ago

Thank you for the clarification. I don't see any errors, but I want to ensure I fully understand every detail on the graph before presenting it. The diverse color theme is effective when it conveys the intended message clearly.

As hydrophobicity can be interpreted through various measures, such as the Kyte-Doolittle (KD) scale, I wanted to ensure that my interpretation aligns with the intended message of the graph. Having color codes for these different properties could enhance the clarity and impact of the visualization.

jbkinney commented 2 months ago

Your question is a good one. I would say don’t trust our classifications of the amino acids. We just took this classification (and color scheme) from some other (not properly documented) source. If you want to make a rigorous map yourself, I suggest using a custom coloring scheme that you define.

Cheers, -Justin

Justin B. Kinney, PhD
Associate Professor
Simons Center for Quantitative Biology
Cold Spring Harbor Laboratory
***@***.***
631-897-5731

On Aug 12, 2024, at 10:38 PM, Yi-Ching Tang @.***> wrote:

External email.


Thank you for the clarification. I don't see any errors, but I want to ensure I fully understand every detail on the graph before presenting it. The diverse color theme is effective when it conveys the intended message clearly.

As hydrophobicity can be interpreted through various measures, such as the Kyte-Doolittle (KD) scale, I wanted to ensure that my interpretation aligns with the intended message of the graph. Having color codes for these different properties could enhance the clarity and impact of the visualization.

— Reply to this email directly, view it on GitHubhttps://github.com/jbkinney/logomaker/issues/39#issuecomment-2285234097, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXOC3BFGO6N5WSVNGRRVH3ZRFWSBAVCNFSM6AAAAABMMRKXM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVGIZTIMBZG4. You are receiving this because you commented.Message ID: @.***>

Disclaimer

The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.

TangYiChing commented 2 months ago

That's cool - customized coloring scheme. I will look into that. Thank you!