first attempt to change to allow resize and avoid infinite loop - Githubissues

jbkunst / d3wordcloud

:cloud: htmlwidgets for D3js Word Cloud Layout

http://rpubs.com/jbkunst/133106

66 stars 15 forks source link

first attempt to change to allow resize and avoid infinite loop #20

Closed timelyportfolio closed 8 years ago

timelyportfolio commented 8 years ago

This can certainly be refined and improved, but for now this pull seeks to address #19.

Summary of Changes

create new drawWordCloud method for use by render and resize
bail out of word cloud instantiation if either width or height are 0 to avoid infinite loop
add resize call
change append to data([0]).enter().append() pattern for reused elements like tooltip
add instance.drawn to avoid adding font multiple times; note, if more than one d3wordcloud in document, multiple same css will be added but not really a problem since cached

jbkunst commented 8 years ago

Thanks Kent!

Ill accept this PR and obviously I'll add you in the DESCRIPTION file if you dont mind.