search

jbkunst / highcharter

R wrapper for highcharts
http://jkunst.com/highcharter/
Other
719 stars 148 forks source link

testthat results: obsolete functions #574

Closed pachadotdev closed 4 years ago

pachadotdev commented 4 years ago 
> devtools::test()
Loading highcharter
Registered S3 method overwritten by 'xts':
  method     from
  as.zoo.xts zoo 
Registered S3 method overwritten by 'quantmod':
  method            from
  as.zoo.data.frame zoo 
Highcharts (www.highcharts.com) is a Highsoft software product which is
not free for commercial and Governmental use
Testing highcharter
√ |  OK F W S | Context
√ |   2       | demos
√ |  20   4   | hchart [2.5 s]
--------------------------------------------------------------------------------
test-hchart.R:9: warning: hchart has a valid class after valid data input
group_by_() is deprecated. 
Please use group_by() instead

The 'programming' vignette or the tidyeval book can help you
to program with group_by() : https://tidyeval.tidyverse.org
This warning is displayed once per session.

test-hchart.R:9: warning: hchart has a valid class after valid data input
select_() is deprecated. 
Please use select() instead

The 'programming' vignette or the tidyeval book can help you
to program with select() : https://tidyeval.tidyverse.org
This warning is displayed once per session.

test-hchart.R:9: warning: hchart has a valid class after valid data input
rename_() is deprecated. 
Please use rename() instead

The 'programming' vignette or the tidyeval book can help you
to program with rename() : https://tidyeval.tidyverse.org
This warning is displayed once per session.

test-hchart.R:106: warning: hchart returns a valid matrix plot after valid data input
mutate_() is deprecated. 
Please use mutate() instead

The 'programming' vignette or the tidyeval book can help you
to program with mutate() : https://tidyeval.tidyverse.org
This warning is displayed once per session.
--------------------------------------------------------------------------------
√ |   1       | Testing utils
√ |   2       | highchart
√ |   5       | showcase [4.1 s]
√ |   2       | themes [0.1 s]

== Results =====================================================================
Duration: 6.7 s

OK:       32
Failed:   0
Warnings: 4
Skipped:  0
nocodehummel commented 4 years ago

The issue can be closed, the deprecated functions are no longer used in the test code.