jbkunst / highcharter

R wrapper for highcharts
http://jkunst.com/highcharter/
Other
720 stars 148 forks source link

Not compatible with flexdashboard #678

Closed GregorDeCillia closed 3 years ago

GregorDeCillia commented 3 years ago

Hello,

I just ran into issues when I tried to use highcharter together with rstudio/flexdashboard. More specifically, the burger icon in the navigation bar is not working in mobile mode.

image

The problem ist that the jQuery version used in highcharter is not compatible with bootstrap - a css library used by flexdashboard. See the following links for more technical details

Is there any way to downgrade or upgrade the jQuery version when using highcharts? I tried including version 3.5.1 of jQuery via a CDN but then highcharts.js was not loading correctly.

Repex:

---
output: flexdashboard::flex_dashboard
---

Info
=====================================     

```{r}
library(highcharter)
highchart(type = "stock") %>% 
  hc_add_series(AirPassengers)
```
StefanMusch commented 3 years ago

I actually ran into this issue today too. Is there any update on whether this is fixable?

@GregorDeCillia did you find a solution to the issue?

StefanMusch commented 3 years ago

This issue can be solved through installing the development version of Flexdashboard. See this issue in the flexdashboard page.

GregorDeCillia commented 3 years ago

@StefanMusch Thanks a lot for reporting this fix! I've been using a private fork of highcharter for the last several months as a workaround where I replaced the jQuery version (Don't do this at home!). This is working fine as far as I can tell, but I'm happy to go back to the dev-version now and enjoy all the goodies that were added since 3a0d330d7a2dc775545446439def503968f34be0 :)

Not sure if this issue should be closed or if we should wait until flexdashboard is shipped to CRAN again. I'll let @jbkunst decide on this.

jbkunst commented 3 years ago

This is solved via updating jquery #722 thanks to @hdrab127