search

jblas-project / jblas

Linear Algebra for Java
http://jblas.org
BSD 3-Clause "New" or "Revised" License
590 stars 149 forks source link

Name of automatic module 'jblas' is unstable, it is derived from the module's file name. #112

Closed KNejad closed 3 years ago

KNejad commented 5 years ago

I am getting this warning in Eclipse when trying to require jblas in a module-info.java file. Would it be possible to add support for Java 11 modules and do any required renames to the project structure to accommodate this?

mikiobraun commented 5 years ago

Can you give a bit more background what would be needed? I'm kinda wary to break backwards compatibility..

KNejad commented 5 years ago

HI @mikiobraun I am fairly new to Java (only a couple of months of experience), so I am not so sure but from what I have read all that is needed is to add a module-info.java file at the root of your project like below. However you may be right that this could break some backwards compatibility. I wish I could help more but truthfully I am just not that experienced with Java.

From what I understand, Java 9+ have modules which give more explicit dependencies. But without a module-info.java file the module is implicitly defined based on the jar name. This can then cause issues if names change. 

module org.jblas {
}
mikiobraun commented 3 years ago

I did a release right now, but for other reasons I'm still building it as Java 8 (javah is missing later and I haven't figured out how to do that yet).

Closing the issue for now, feel free to repon.