jblas-project / jblas

Linear Algebra for Java
http://jblas.org
BSD 3-Clause "New" or "Revised" License
590 stars 149 forks source link

fixed [Float|Double]Matrix.get(Range,Range) #13

Closed cheshirekow closed 12 years ago

cheshirekow commented 12 years ago

Fix for issue #12

mikiobraun commented 12 years ago

Hi Cheshirekow,

thanks for the fix! I thought I had fixed a similar bug... Hm... Have to check.

Thanks anyway for the pull request!

-M

On Fri, Jan 6, 2012 at 6:43 PM, cheshirekow reply@reply.github.com wrote:

Fix for issue #10

You can merge this Pull Request by running:

 git pull https://github.com/cheshirekow/jblas master

Or you can view, comment on it, or merge it online at:

 https://github.com/mikiobraun/jblas/pull/13

-- Commit Summary --

  • added cs.init() in rowloop of get(Range,Range) methods

-- File Changes --

M src/main/java/org/jblas/DoubleMatrix.java (1) M src/main/java/org/jblas/FloatMatrix.java (1)

-- Patch Links --

 https://github.com/mikiobraun/jblas/pull/13.patch  https://github.com/mikiobraun/jblas/pull/13.diff


Reply to this email directly or view it on GitHub: https://github.com/mikiobraun/jblas/pull/13

Dr. Mikio Braun, Beckerstr. 11, 12157 Berlin Privat: 030 / 42 10 56 42, Büro: 030 / 314 78627, Handy: 0172 / 97 45 676

cheshirekow commented 12 years ago

No problem. From the history, it looks like you fixed essentially the same problem in Matrix.set(Range,Range,Matrix).