getRows with IntervalRange problems

[Neiko2002]

The method "public DoubleMatrix getRows(Range indices, DoubleMatrix result)" uses the indices.index() instead of the values. Resulting in problems when try to get some rows in the middle.

e.g.: DoubleMatrix m = new DoubleMatrix(new double[][]{{1,1,1},{2,2,2},{3,3,3},{4,4,4}}); DoubleMatrix m1 = m.getRows(new IntervalRange(0, 2)); DoubleMatrix m2 = m.getRows(new IntervalRange(2, m.getRows()));

m1 and m2 have the same values.

[mikiobraun]

Hi Nico,

thanks for writing. I'll check.

-M Am 03.06.2013 16:54 schrieb "Nico Hezel" notifications@github.com:

The method "public DoubleMatrix getRows(Range indices, DoubleMatrix result)" uses the indices.index() instead of the values. Resulting in problems when try to get some rows in the middle.

e.g.: DoubleMatrix m = new DoubleMatrix(new double[][]{{1,1,1},{2,2,2},{3,3,3},{4,4,4}}); DoubleMatrix m1 = m.getRows(new IntervalRange(0, 2)); DoubleMatrix m2 = m.getRows(new IntervalRange(2, m.getRows()));

m1 and m2 have the same values.

— Reply to this email directly or view it on GitHubhttps://github.com/mikiobraun/jblas/issues/29 .

[mikiobraun]

Yes, you're right. Corrected that. Also added a getColumns with Ranges. Was missing for some reason.

Thanks!

-M