jblas-project / jblas

Linear Algebra for Java
http://jblas.org
BSD 3-Clause "New" or "Revised" License
590 stars 149 forks source link

Recursion, hashCode issue and a few other suggestions #39

Closed srowen closed 10 years ago

srowen commented 10 years ago

Mikio I thought I'd suggest a few more things. This patch fixes what seems to be an inadvertent infinite recursion in ComplexDoubleMatrix.putReal; it just calls itself instead of the method that takes int[]. I also believe that equals() needs to be defined to be transitive, so needs exact-equality semantics, and needs a hashCode() as well, in the Complex* classes. What do you think?

I also put in a few changes from inspection along the way, like removing unused imports, avoiding a manual array copy, etc. Really small things.

mikiobraun commented 10 years ago

Hi @srowen,

thanks a lot! Pulled all your suggestions.

Sorry for the lack of updates. I've got adding a few functions from LAPACK in my pipeline for some time. Unfortunately, they are only available in more recent versions of lapack-lite, but they've changed their comment format so my magic Rubyscripts don't work anymore and I'd need to put in some serious time which I don't have right now, unfortunately.

Best,

-M