search

jblas-project / jblas

Linear Algebra for Java
http://jblas.org
BSD 3-Clause "New" or "Revised" License
590 stars 149 forks source link

org.jblas.FloatMatrix.loadCSVFile() prints to System.out #74

Closed shanishalgi closed 4 years ago

shanishalgi commented 8 years ago

Hello,

The loadCSVFile() method in the FloatMatrix class contains the following line:

System.out.println("Done reading file");

(Line 2085 in org.jblas.FloatMatrix.java in the jblas-1.2.3.jar available via Maven.)

imho - making applications which use JBlas print messages they did not intend to seems like a bad idea. It would be nicer if this was either a. removed, or b. made optional via some verbosity flag.

mikiobraun commented 4 years ago

Hey, shanishalgi thanks for the very late reply.

I totally agree, thanks for the hint!

mikiobraun commented 4 years ago

fixed it.