Currently, org.jblas.TestDoubleMatrix::testColumnAndRowMinMax() only exercises the loop in org.jblas.DoubleMatrix::argmin() such that the the element at index 0 is always returned as the min, although there is no specification for an input array that is sorted in ascending order. Similar argument for the other min functions in that test case. This PR adds org.jblas.TestDoubleMatrix::testColumnAndRowMinMaxUnsorted() to increase loop coverage, and find the min when the input array is unsorted.
mikiobraun
commented
6 years ago
Currently,
org.jblas.TestDoubleMatrix::testColumnAndRowMinMax()only exercises the loop inorg.jblas.DoubleMatrix::argmin()such that the the element at index 0 is always returned as the min, although there is no specification for an input array that is sorted in ascending order. Similar argument for the other min functions in that test case. This PR addsorg.jblas.TestDoubleMatrix::testColumnAndRowMinMaxUnsorted()to increase loop coverage, and find the min when the input array is unsorted.