search

jblindsay / whitebox-tools

An advanced geospatial data analysis platform
https://www.whiteboxgeo.com/
MIT License
967 stars 161 forks source link

Trend Surface tool suggested improvement to documentation #421

Closed Hornbydd closed 4 months ago

Hornbydd commented 4 months ago

I have been exploring the Trend Surface tool, with the idea of detrending a DEM for hydrological analysis. I wanted to compare this tool against the Trend tool in ArcPro.

The help file says:

Numerical stability is enhanced by transforming the x, y, z data by their minimum values before performing the regression analysis. These transform parameters are also reported in the output report.

To a non specialist in this subject what does transforming the x, y, z data by their minimum values mean and what does that entail? Here I think the help file needs updating to explain what this means.

jblindsay commented 4 months ago

Thanks Duncan, I've modified it so that it states: "Numerical stability is enhanced by transforming the x, y, z data by subtracting their minimum values before performing the regression analysis. These transform parameters are also reported in the output report."

asub-sandwich commented 4 months ago

After this fix, building now raises an error in tools/lidar_analysis/ascii_to_las.rs:391:25 line_data (389) is not mutable but re-assigned at 391.

jblindsay commented 4 months ago

Thanks for catching that @asub-sandwich. I've just uploaded a fix for that.