jblindsay / whitebox-tools

An advanced geospatial data analysis platform
https://www.whiteboxgeo.com/
MIT License
942 stars 161 forks source link

FillBurn enters infinite loop #51

Open johnniehard opened 4 years ago

johnniehard commented 4 years ago

When trying to run the FillBurn tool it enters an infinite loop, and soon crashes from running out of RAM (6MB input raster ends up trying to use over 16GB RAM).

This is the loop that goes out of control: https://github.com/jblindsay/whitebox-tools/blob/master/src/tools/hydro_analysis/fill_burn.rs#L503

It ends up reporting over 30000% progress.

Does this happen for anyone else?

jblindsay commented 4 years ago

I certainly appreciate you reporting this issue and I'll look into it soon. I have hopes to introduce the topological breach-burn stream burning method to the library very soon as well, and so this is a high priority to me.

wyowill commented 4 years ago

I'm running WBT v1.3.1 via Python, but can't find the "topological breach burn" tool (this thread was the only entry that popped-up in my search). Based on your ESPL paper, the results look quite good. Is it presently available via a different environment/implementation (e.g. GAT)?

jblindsay commented 4 years ago

The TopologicalBreachBurn tool is currently available in Whitebox GAT and hasn't yet been ported to WhiteboxTools. If you like, please raise a separate issue requesting the addition of the tool to WhiteboxTools. This will bump it up the priority list.