Closed jbloomAus closed 1 month ago
Attention: Patch coverage is 43.47826%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 67.27%. Comparing base (
91239c1
) to head (b3b28f6
).
Files | Patch % | Lines |
---|---|---|
sae_lens/training/lm_runner.py | 23.52% | 13 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
I'm removing the ability to resume a previous run, but keeping the "save SAE on ctrl c" functionality which came with that features. As with SAE dictionaries, this is about cleaning up the code and making room for cleaner code. I realise that this regression might make it hard to work with compute that may be revoked mid-job. However, this is not a use case we intend to support in the short - medium term.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)Performance Check. (not relevant)
If you have implemented a training change, please indicate precisely how performance changes with respect to the following metrics: