jbloomAus / SAELens

Training Sparse Autoencoders on Language Models
https://jbloomaus.github.io/SAELens/
MIT License
193 stars 67 forks source link

remove resuming ability, keep resume config but complain if true #156

Closed jbloomAus closed 1 month ago

jbloomAus commented 1 month ago

Description

I'm removing the ability to resume a previous run, but keeping the "save SAE on ctrl c" functionality which came with that features. As with SAE dictionaries, this is about cleaning up the code and making room for cleaner code. I realise that this regression might make it hard to work with compute that may be revoked mid-job. However, this is not a use case we intend to support in the short - medium term.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

Performance Check. (not relevant)

If you have implemented a training change, please indicate precisely how performance changes with respect to the following metrics:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.27%. Comparing base (91239c1) to head (b3b28f6).

Files Patch % Lines
sae_lens/training/lm_runner.py 23.52% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ========================================== - Coverage 71.62% 67.27% -4.35% ========================================== Files 18 18 Lines 1815 1794 -21 Branches 287 282 -5 ========================================== - Hits 1300 1207 -93 - Misses 448 522 +74 + Partials 67 65 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.