Currently make format will format jupyter notebooks if the user has the black jupyter extension installed. We don't check this in CI though, so it can cause a huge amount of formatting changes for all notebooks when the users runs make format. We should either explicitly block .ipynb files from make format, or we should explicitly add the black jupyter extension as a dependency and check notebook formatting in CI.
My personal preference would be to add the black jupyter notebook plugin and explicitly check in CI to make our notebooks slightly more consistent, but also don't have a strong opinion.
Checklist
[x] I have checked that there is no similar issue in the repo (required)
Proposal
Currently
make format
will format jupyter notebooks if the user has the black jupyter extension installed. We don't check this in CI though, so it can cause a huge amount of formatting changes for all notebooks when the users runsmake format
. We should either explicitly block.ipynb
files frommake format
, or we should explicitly add the black jupyter extension as a dependency and check notebook formatting in CI.My personal preference would be to add the black jupyter notebook plugin and explicitly check in CI to make our notebooks slightly more consistent, but also don't have a strong opinion.
Checklist