Closed chanind closed 3 weeks ago
@chanind Do we know what the scale of the impact of this bug might have been?
Seems like it would only be an issue for SAEs trained with normalize_activations='expected_average_only_in'
, which isn't the default. I'm struggling to get tests to pass with this fix though, the final assertion fails with this fix
Looks like the issue was just with the way tests were scaling the output, should be fixed now.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.85%. Comparing base (
4c32de0
) to head (7604d74
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Merging as it's currently broken in prod, and seems pretty had to argue with. Thanks @tuomaso!
Description
This PR implements the fix specified in #354 and updates tests.
Fixes #354
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)