Closed chanind closed 3 weeks ago
Attention: Patch coverage is 80.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 66.14%. Comparing base (
b8703fe
) to head (18143b7
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
sae_lens/toolkit/pretrained_sae_loaders.py | 80.00% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I noticed that as well - it looks like the neuronpedia_id property is only set on the config in the SAE, but not in the config_dict that gets returned from SAE.from_pretrained()
. I'm not sure what the reason for that is, or if it's simply an oversight. I can add it to the the config_dict so it's set every if that makes more sense. I'm also not sure what the idea with the neuronpedia
property is
I updated the PR to include neuronpedia_id
in the config in both places. I think the neuronpedia
properly was likely just a typo, since there's no equivalent property on the SAEConfig class.
Description
This PR unifies the code path for
from_pretrained
andget_sae_config
so the config dict should match, and adds a test asserting this for a jbloom/gpt2 SAE.Fixes #351
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)