Open chanind opened 7 months ago
I can work on this this week.
@chanind I was thinking that as part of this, we should also change
to
expansion_factor: Optional[int] = None
since it's less explicit to check if expansion_factor
is 4
than None
to check if it's been set. However, people would always have to pass a value for either d_sae
or expansion_factor
when they instantiate LanguageModelSAERunnerConfig
. What do you think?
seems good
I think that sounds reasonable! But just make sure that if both expansion_factor
is None
, and d_sae
is None
, then expansion_factor
should default to 4
for backwards compatibility. This can be noted in the docstring and also as a comment after expansion_factor: Optional[int] = None # defaults to 4 if d_sae and expansion_factor is None
These are both ways of setting the size of the SAE