jbloomlab / SARS-CoV-2-RBD_DMS

Deep mutational scanning of the receptor-binding domain of SARS-CoV-2 Spike
BSD 3-Clause "New" or "Revised" License
43 stars 17 forks source link

Interactive heatmap #60

Closed skhilton closed 4 years ago

skhilton commented 4 years ago

This PR updates the interactive_heatmap.ipynb and the resulting results/interactive_heatmap.html.

In the new interactive heatmap:

Next steps include

Final note: I know that other bloom lab repos have github pages served from a gh-pages branch. Github now suggests that you serve from your master branch but in a docs folder. However, in this case, maybe a gh-pages branch makes sense? I could tweak things for the website without pushing to master directly.

skhilton commented 4 years ago

@jbloom: I haven't looked at the snakemake pipeline so I will have to work with @tylernstarr on that.

Your point about the up-to-date data makes sense. Let's go with that. I will work on getting a basic index.html up and working. Let's hold off on this PR until those two steps (snakemake integration and docs/index.html are done

jbloom commented 4 years ago

@tylernstarr @skhilton, I can also put in Snakemake pipeline if that is easier. Just let me know? @tylernstarr has been doing this a lot for *.Rmd, but I can do for Juypyter if easier.

I think once that is done this could potentially be merged and the GitHub pages could be a separate pull request?

tylernstarr commented 4 years ago

@jbloom yes I was just about to look at this and was overwhelmed a bit by my ineptitude. I could figure out the Snakemake but you can probalby do much more quickly. Especially with this impending 5pm shutoff! I probably wouldn't make it... 😬

tylernstarr commented 4 years ago

(I did look at the html though and definitely approve that part of the PR! Looking so good!)