search

jbloomlab / dms_tools2

software for the analysis and visualization of deep mutational scanning data
GNU General Public License v3.0
29 stars 20 forks source link

Issue with fastq-dump version string #61

Closed FlyinTeller closed 2 years ago

FlyinTeller commented 2 years ago

There is an issue with the version string from fastq-dump, at least in sratoolkit 2.11. The output of fastq-dump --version does not seem to contain a :

sratoolkit.2.11.0-ubuntu64/bin/fastq-dump --version

"sratoolkit.2.11.0-ubuntu64/bin/fastq-dump" version 2.11.0

This breaks the logic in sra.py for the version check

This has also been reported here

jbloom commented 2 years ago

The updated version is now on PyPI as 2.6.11.

FlyinTeller commented 2 years ago

Thanks, I have added that info to the SO post so users with a similar issue will find this information