search

jbloomlab / dms_variants

Analyze deep mutational scanning of barcoded variants.
Other
6 stars 9 forks source link

adds ftol as option to fit_models #81

Closed caelanradford closed 2 years ago

caelanradford commented 2 years ago

This adds ftol as an option to fit_models, which will be helpful for looking at different parameters and likelihood types when fitting and comparing global epistasis models.

jbloom commented 2 years ago

@caelanradford, if you still want to make this change, I have fixed the failing tests so you can rebase on top of the current master branch and then make changes above.

jbloom commented 2 years ago

@caelanradford, I pushed two more commits to this so it passes tests and version is updated. Should I go ahead and merge this or do you have more related changes first?

caelanradford commented 2 years ago

You can go ahead and merge. Thanks.