Closed ckikawa closed 6 months ago
I think we should add instructions to the README.md, if was not immediately obvious that this is what should be done, an example would work.
Yes, you are correct that this was a bug fix. However, there is not currently an example of how a single well or a barcode should be listed for exclusion. It was unclear if they should be in brackets around the entry or if these could just be listed as strings. I would recommend we update the README.md section on manual drops to show an example of each, i.e.:
manual_drops: barcode_serum_replicates:
It should just be a list, which can be specified in either of two ways in YAML:
wells: [A1, A2]
or
wells:
- A1
- A2
It says this verbally in README, but you can add in example if you want @ckikawa
@jbloom, I see. I think this was just a YAML formatting quirk that I wasn't familiar with. I was trying (and failing) with:
wells:
- [A1, A2]
I've updated the CHANGELOG but I'm not sure an example in README is necessary.
This pull request should resolve #45 by adding additional
elif
statements to a cell ofprocess_plate.ipynb
where manual_drops are removed from thecounts
dataframe. I tested this with multiplewells
on some recent H3N2ngs-neut
data.As is, single wells/barcodes cannot be specified in lists (as indicated in
README
). They must be added as individual lines with dashes. If this is expected behavior, ignore this comment. Otherwise, I can add this detail toREADME
?