Fetch imdb ID from existing nfo file first

[GoogleCodeExporter]

I am not sure how difficult is to solve, or if you even consider this, but
would be great that similarly to xbmc emm would try to fetch imdb id from
"non-compliant" scene nfo files(the same which are going to be renamed to
.info) prior to search on imdb based on the folder name. 

Original issue reported on code.google.com by nadas.bence@gmail.com on 20 May 2009 at 10:16

[GoogleCodeExporter]

This was requested before (I guess it was on my old To Do list and not on here) 
so I
guess I need to work on this some time. lol

Original comment by jason.schnitzler on 21 May 2009 at 12:21

• Changed state: Accepted

[GoogleCodeExporter]

Done in r118.

Original comment by jason.schnitzler on 22 May 2009 at 7:40

• Changed state: Done

[GoogleCodeExporter]

This seems not working at me. IS there anything special to know about that?

I created an <moviname>.nfo file for one of my movies, which is not recognized 
based
on the folder name.

The contain of the nfo:
imdb  http://www.imdb.com/title/tt0286516/

But emm is still asking for my input to choose the movie.

Original comment by nadas.bence@gmail.com on 22 May 2009 at 10:30

[GoogleCodeExporter]

That should work. Before we get too far into it, do you have <movie>.nfo 
selected in
settings?

Original comment by jason.schnitzler on 22 May 2009 at 5:54

[GoogleCodeExporter]

Yes, I do.
How can I help you to track this down?

Original comment by nadas.bence@gmail.com on 22 May 2009 at 6:10

[GoogleCodeExporter]

Hmmm... is the .nfo renamed to .info? Is there an error log?

Original comment by jason.schnitzler on 22 May 2009 at 6:13

[GoogleCodeExporter]

Some further testing:
It's ok on single scraping, but not using auto-update.
On auto update, emm only renaming the .nfo to .info, but new .nfo is not get 
created.

Original comment by nadas.bence@gmail.com on 22 May 2009 at 7:04

[GoogleCodeExporter]

Sorry, I meant "not WHEN using auto-update"... lol. Have to improve my english 
:)

Original comment by nadas.bence@gmail.com on 22 May 2009 at 10:11

[GoogleCodeExporter]

Fixed for next release. Should have only happened on either of the update-ask
methods, but not for update-auto or single scrape. It was always loading a new, 
black
movie during update-ask if the data could not be loaded from nfo.

Original comment by jason.schnitzler on 22 May 2009 at 11:19

[GoogleCodeExporter]

I just tested it. It's still not ok with the same symphtom.

Original comment by nadas.bence@gmail.com on 23 May 2009 at 5:44

[GoogleCodeExporter]

Which method are you using to scan the files?

Original comment by jason.schnitzler on 23 May 2009 at 5:51

[GoogleCodeExporter]

duhhh... I wanted to feedback this for IMDB rating.

But this one is neither ok:

 - working with single-scrape with the outside button
 - not working with sigle srcape "edit inside" button
 - not working with update-ask

Original comment by nadas.bence@gmail.com on 23 May 2009 at 5:54

[GoogleCodeExporter]

The "outside" and "inside" buttons use the same code. In fact, all the "inside"
button does is close the movie editor then call the same function as the 
"outside"
button. Just to clarify, once you do it for the first time, the file is 
renamed... so
it won't pick it back up the second time you attempt it. You'd have to rename 
the
file back to *.nfo.

Original comment by jason.schnitzler on 23 May 2009 at 5:58

[GoogleCodeExporter]

Sure I did that. And tried twice. 

But now I tried again and it worked. I feel stupid now, but I am pretty sure I 
tried
in the good way. Something was around under the hood :)

but it's definitely not ok with update-ask. I tried it 5 times now. lol

Original comment by nadas.bence@gmail.com on 23 May 2009 at 6:06

[GoogleCodeExporter]

Ah, I see what the problem is. I'll fix it in a bit.

Original comment by jason.schnitzler on 23 May 2009 at 6:11

[GoogleCodeExporter]

OK, finally I succesfully figured out I am not completely stupid. lol

 - If I use the inside button if I get inside with edit movie, then inside button is ok
 - But if I get in with doubleclick on the movie in the movie list, then it's just
rename the .nfo to .info, but scraping is not starting and no new .nfo file 
created.

Original comment by nadas.bence@gmail.com on 23 May 2009 at 6:18

[GoogleCodeExporter]

Hopefully r134 fixes it. ;)

Original comment by jason.schnitzler on 23 May 2009 at 7:56

[GoogleCodeExporter]

Great, it's okay now on auto update-ask. Thank you!

But re-scraping with the inside button is still not OK, if I get into edit 
window via
doubleclick. At least surely not for checking the non-compliant .nfo.

Original comment by nadas.bence@gmail.com on 23 May 2009 at 9:06

[GoogleCodeExporter]

lol I forgot to put the code to handle the "inside" button when double-clicking 
the
movie list. It's in SVN now.

Original comment by jason.schnitzler on 23 May 2009 at 4:53

[GoogleCodeExporter]

:)
However, unfortunately it's still not OK.
But something has been changed.
Previously, as I mentioned emm was just renaming .nfo to .info and nothing else 
happened.
Now it is renaming .nfo to .info and pops up the search window to choose a 
movie.

Original comment by nadas.bence@gmail.com on 23 May 2009 at 5:08

[GoogleCodeExporter]

Try with r140. I think the problem was when it was loading the nfo to just 
display on
screen, it was renaming it to .info. Then when you double-clicked it, the nfo 
was
already renamed and therefore didn't exist to get the IMDB ID from. I made it 
so that
it doesn't rename the files when it's just loading the nfo to display. Let me 
know if
that works. Thanks!

Original comment by jason.schnitzler on 23 May 2009 at 5:37

[GoogleCodeExporter]

Uhhhh, something went terribly wrong now.

Now, it's not working in any way, with different symphtoms.

 - On double click: same as before
 - On single-scrape with outside button it is working, but overwrite .nfo without
renaming it to .info
 - On auto-update-ask(missing info) .nfo renamed to .info, poster scraped, but .nfo
is not created at all

Original comment by nadas.bence@gmail.com on 23 May 2009 at 5:49

[GoogleCodeExporter]

No, wait, I screwed up something.

Original comment by nadas.bence@gmail.com on 23 May 2009 at 5:54

[GoogleCodeExporter]

lol,

Actually it's working _fine_ only with doubleclick, then inside button.

- On single-scrape with outside button it is working, but overwrite .nfo without
renaming it to .info
 - On auto-update-ask(missing info) .nfo renamed to .info, poster scraped, but .nfo
is not created at all

Original comment by nadas.bence@gmail.com on 23 May 2009 at 5:59

[GoogleCodeExporter]

Forgot to mark it in the SVN comments, but I did a tweak to this as well. 
Instead of
renaming the file when it's reading it, I moved the rename code to when it's 
saving.
Makes more sense that way, and should fix all the problems.

Original comment by jason.schnitzler on 23 May 2009 at 6:55

[GoogleCodeExporter]

IT seems we are almost there:

 - single-scraping is working with all method/ button
 - but during autoupdate-missing-ask: imdb id pulled succesfully, movie found, poster
downloaded, but .nfo is remain the same. It won't get renamed, neither 
overwrote. It
just still the same-old non-compliant one.

Original comment by nadas.bence@gmail.com on 23 May 2009 at 7:39

[GoogleCodeExporter]

Ah, I see.... because it's not processing it. Since there is an nfo file there, 
it
doesn't think it needs to update it. I'll fix that right now.

Original comment by jason.schnitzler on 23 May 2009 at 7:57

[GoogleCodeExporter]

Damn... that really slows things down. Got to think of a better way to do this.

Original comment by jason.schnitzler on 23 May 2009 at 8:10

[GoogleCodeExporter]

Ok, re-wrote a couple things and now it checks for valid nfo before doing a 
missing
items update. Hopefully this one works. *fingers crossed*

Original comment by jason.schnitzler on 23 May 2009 at 9:16

[GoogleCodeExporter]

Wow Jason, you finally get there. It's working all the way.
It's amazing! Thank you!

And something which I also notified:
emm is not asking for an input to choose poster if there is no poster find at 
all...
This is also very nice! Did you add a code for this, or it is some side effect? 
:)

Again, thank you very much for this feature! 

Original comment by nadas.bence@gmail.com on 23 May 2009 at 9:46

[GoogleCodeExporter]

Excellent! Thanks! Yeah, it got annoying during testing for this issue for it 
to pop
up "could not find preferred image" and then say "no images found". lol I had 
to fix
that.

Original comment by jason.schnitzler on 23 May 2009 at 9:54

• Changed state: Verified