search

jbms / beancount-import

Web UI for semi-automatically importing external data into beancount
GNU General Public License v2.0
393 stars 103 forks source link

beancount_import 1.3.3 doesn't contain `generic_import_source` #118

Closed georggrab closed 2 years ago

georggrab commented 3 years ago

Hi! Thanks for this project, it helps a lot. Here's a thing I noticed - beancount-import 1.3.3 (latest version at time of writing), as published on pypi doesn't seem to contain generic_import_source. I get an error when specifying it as a data source.

See for example:

wget https://files.pythonhosted.org/packages/cb/b3/a4fbc28c957c8ff5ce5686ec71d8df301b4d61a73b839fa6f7b4960b2ff5/beancount-import-1.3.3.zip
unzip beancount-import-1.3.3.zip
ls beancount-import-1.3.3/beancount_import/source                                          1
amazon_invoice.py             __init__.py           stockplanconnect.py
amazon_invoice_sanitize.py    link_based_source.py  stockplanconnect_statement.py
amazon_invoice_test.py        mint.py               ultipro_google.py
amazon.py                     mint_test.py          ultipro_google_statement.py
amazon_test.py                ofx.py                venmo.py
description_based_source.py   ofx_sanitize.py       venmo_sanitize.py
google_purchases.py           ofx_test.py           venmo_test.py
google_purchases_sanitize.py  paypal.py             waveapps.py
google_purchases_test.py      paypal_sanitize.py    waveapps_test.py
healthequity.py               paypal_test.py
healthequity_test.py          source_test.py

If I install the project from the master branch, everything works as expected:

(install from master branch as per README instructions)
ls ~/.local/lib/python3.9/site-packages/beancount_import/source 
amazon_invoice.py                healthequity_test.py  schwab_csv.py
amazon_invoice_sanitize.py       __init__.py           schwab_csv_test.py
amazon_invoice_test.py           link_based_source.py  source_test.py
amazon.py                        mint.py               stockplanconnect.py
amazon_test.py                   mint_test.py          stockplanconnect_statement.py
description_based_source.py      ofx.py                ultipro_google.py
generic_importer_source.py       ofx_sanitize.py       ultipro_google_statement.py
generic_importer_source_test.py  ofx_test.py           venmo.py
google_purchases.py              paypal.py             venmo_sanitize.py
google_purchases_sanitize.py     paypal_sanitize.py    venmo_test.py
google_purchases_test.py         paypal_test.py        waveapps.py
healthequity.py                  __pycache__           waveapps_test.py

I guess the generic importer source will only be available in a future released version of the project, might be worth specifying this in the Readme. Thanks!

bsiebens commented 3 years ago

I too would love to get a new version containing the generic_import_source piece.

calys commented 3 years ago

me too!

moritzj29 commented 2 years ago

I wanted to give this project a try today, but even the examples from the repo do not work with the package from pypi due to this issue. I don't want to setup node.js just to get this running... Hope this gets fixed soon!

jbms commented 2 years ago

Just pushed v1.3.4.