search

jbms / sphinx-immaterial

Adaptation of the popular mkdocs-material material design theme to the sphinx documentation system
https://jbms.github.io/sphinx-immaterial/
Other
191 stars 29 forks source link

Fix type_annotation_transforms for Sphinx 6 #181

Closed jbms closed 1 year ago

jbms commented 1 year ago

I think I've fixed all of the typing issues now. Unfortunately the setup-graphviz seems to be failing now on macOS, not sure how we can work around that.

2bndy5 commented 1 year ago

There seems to be a conflict between the installed python and the python homebrew tries to install. Although I can't clearly tell what the problem is. My instinct is to setup-graphviz before setup-python in the CI.

2bndy5 commented 1 year ago

We might be able to get graphviz through conda-forge instead of OS-specific pkg managers (like the current action does).

2bndy5 commented 1 year ago

Damn. I still have no idea what the problem is based on the homebrew output.

jbms commented 1 year ago

I think this is a general issue with using homebrew on github actions. Reordering the graphviz step before the Python setup step did not fix the issue, but skipping brew update seems to avoid the issue.

https://github.com/ts-graphviz/setup-graphviz/issues/457

jbms commented 1 year ago

Perhaps we should tag a new version with Sphinx 6 support?

2bndy5 commented 1 year ago

sure, but I was thinking a patch bump.