jbms / sphinx-immaterial

Adaptation of the popular mkdocs-material material design theme to the sphinx documentation system
https://jbms.github.io/sphinx-immaterial/
Other
191 stars 29 forks source link

Fix to use ts-graphviz/setup-graphviz again on CI #201

Closed kamiazya closed 1 year ago

kamiazya commented 1 year ago

CI failed due to setup-graphviz behavior on macOS, so we no longer use ts-graphviz/setup-graphviz in PR #181.

In ts-graphviz/setup-graphviz@v1.2.0, this issue has been resolved and we are now using it again.

kamiazya commented 1 year ago

I have confirmed that Graphviz can be installed on macOS, but mypy has FAILED.

I know this is probably a different issue than this fix, but is there anything I can do to help?

2bndy5 commented 1 year ago

Looks like we'll have to fix the mypy issues separately. It is unfortunate to not get see the fix in action.

❤️ the quick response time and involvement on behalf of @ts-graphviz, thanks for this!

kamiazya commented 1 year ago

@2bndy5 We appreciate your report on the issue as well.

You can see that the fix has been applied in the JOB below. The step with setup-graphviz is succesful and brew update is not running.

https://github.com/jbms/sphinx-immaterial/actions/runs/3853882835/jobs/6567324527

kamiazya commented 1 year ago

It is not a mypy issue, but may be affected by yesterday's release of Sphinx 6.1 series.

If mypy is right and the internals of the sphinix Python module have been changed, it may affect other users of this module, so it may be better to create a separate issue to deal with this issue.

I have no domain knowledge of this project or Sphinix, so I can't judge, but please refer to the following link.

jbms commented 1 year ago

Thanks, can you change this to specify the action version by exact hash rather than version number?

jbms commented 1 year ago

The mypy failure appears to indicate a real incompatibility with 6.1 that we will need to fix.

kamiazya commented 1 year ago

@jbms Fixed the version specification of the action to be fixed by Git hash.

jbms commented 1 year ago

Mypy issue should be fixed by https://github.com/jbms/sphinx-immaterial/pull/202

2bndy5 commented 1 year ago

@kamiazya Can you rebase on latest main? #202 has been merged to main.

kamiazya commented 1 year ago

@2bndy5 Merged main.

I used GitHub's Fork Sync, so it was a merge commit, but the result will be the same :pray:

jbms commented 1 year ago

Thanks!