jbms / sphinx-immaterial

Adaptation of the popular mkdocs-material material design theme to the sphinx documentation system
https://jbms.github.io/sphinx-immaterial/
Other
191 stars 29 forks source link

Improve CSS/JavaScript bundling and fix miscellaneous issues #205

Closed jbms closed 1 year ago

jbms commented 1 year ago
2bndy5 commented 1 year ago

Thanks for doing this! I was clearly fumbling around with the generated bundles...

Is the Google API key here allowed to be openly redistributed?

jbms commented 1 year ago

Thanks for doing this! I was clearly fumbling around with the generated bundles...

Is the Google API key here allowed to be openly redistributed?

This key is already effectively public --- if you visit

https://developers.google.com/fonts/docs/developer_api

open Dev Tools and click Execute in the "API explorer" side bar, you will see that a request is made from the client with this exact key.

In general I don't know why the Google Fonts API requires a key at all, since the entire API that requires a key just consists of receiving a single static 130KB JSON file, and the fonts themselves (which amount to a much larger amount of data and require more sophisticated request handling) can be retrieved without an API key.

It is also relatively easy to just create a Google Cloud project and obtain an API key (there are no charges), but I didn't want to bother with that as long as this key works.