jbms / sphinx-immaterial

Adaptation of the popular mkdocs-material material design theme to the sphinx documentation system
https://jbms.github.io/sphinx-immaterial/
Other
177 stars 28 forks source link

update external_cpp_references #257

Closed 2bndy5 closed 1 year ago

2bndy5 commented 1 year ago

This partially addresses the observations in https://github.com/jbms/sphinx-immaterial/issues/115#issuecomment-1172809791

jbms commented 1 year ago

This change looks good since we are already stripping leading ":" in _strip_template_arguments. However, I'm rather confused why we weren't getting nitpick warnings before.

2bndy5 commented 1 year ago

Nitpick warnings about what exactly? The only nitpick warning this relieves is the one about the python class.

jbms commented 1 year ago

Nitpick warnings about what exactly? The only nitpick warning this relieves is the one about the python class.

Oh sorry, I was getting confused between external_cpp_references and the nitpick warnings on namespaces.