Open duncanmmacleod opened 1 month ago
If the purpose of the variable is to allow user customization, then it should be exposed as a config option. I'd rather not encourage monkey patching when it isn't necessary.
And yes, the suggested patch would be the solution if user customization is not preferred for some reason.
The
_MAX_CONCURRENT_FETCHES
module variable insphinx_immaterial.google_fonts
is currently unused:I presume this is supposed to be a way for users to monkeypatch a lower (or higher) concurrency limit to help with network issues, but it isn't used in the call to
ThreadPoolExecutor
.Presuming my understanding is correct, is this the right fix?