search

jbmusso / gremlin-javascript

JavaScript tools for graph processing in Node.js and the browser inspired by the Apache TinkerPop API
MIT License
214 stars 63 forks source link

Fixes #100 - Add support for tinkerpop gremlin server 3.3 (GraphSONMessageSerializerV3d0) #101

Closed ctdio closed 6 years ago

ctdio commented 6 years ago

This PR adds support usage with Tinkerpop Gremlin Server 3.3 (which uses GraphSONMessageSerializerV3d0).

A lot of the changes come from prettier doing it's formatting. The main change is in executeHandler.js and GremlinClient.js, which in both cases simply tries to use the data object's @value property if it exists and will fallback to using data. The rest of the changes were done to allow tests to be run with both 3.2 and 3.3.

I was originally going to normalize the incoming data into a nicer format (the new format is a pain to parse), but it is probably best to offload that work to consumers of this library.

ctdio commented 6 years ago

@jbmusso could I get some feedback on this PR?