Improve browser support with tests and slim dependencies

jbmusso / gremlin-javascript

JavaScript tools for graph processing in Node.js and the browser inspired by the Apache TinkerPop API

MIT License

214 stars 62 forks source link

Improve browser support with tests and slim dependencies #30

Open jbmusso opened 8 years ago

jbmusso commented 8 years ago

Browser support should be improved:

add appropriate tests
remove dependencies/unsure the slimmest possible bundle

dmill-bz commented 8 years ago

FYI iOS browsers run in strict mode and throw the following error:

Const declarations are not supported in strict mode.

jbmusso commented 8 years ago

This is weird. The code published to npm (and its dependencies) is transpiled to ES5 and shouldn't have any const declarations (only var). Could you be more specific as to how you import the client to your application?

dmill-bz commented 8 years ago

I originally thought it was because of some of your dependencies (and you excluding node_modules from webpack). But looking at the code again it seems to remove all const appropriately. Wonder why the behavior on gremlin-bin is different. I'll give this another look.