search

jbmusso / gremlin-javascript

JavaScript tools for graph processing in Node.js and the browser inspired by the Apache TinkerPop API
MIT License
214 stars 62 forks source link

trying newer instanbul #37

Closed dmill-bz closed 8 years ago

dmill-bz commented 8 years ago

Temp PR just to check build and coverage. You can ignore for now.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.3%) to 95.833% when pulling f343d9c07021a827ef7eebf319ace7fbd0fcec91 on coverals-maps-fix into ef9d2edc9bdc80851ef90c9f26490936d2dbba33 on master.

dmill-bz commented 8 years ago

Ok, so basically this PR updates istanbul. What comes from this is that before this PR the coverage was done on the lib/* files. This is 1) giving an incorrect result and 2) means you can't get file reports in coveralls.

This PR fixes this and uses src/* files correctly. Though the file reports seem very minimal, it seems to only tell you which methods are being checked? see here : https://coveralls.io/builds/5500079/source?filename=src%2FGremlinClient.js

I don't know if this is a normal level of coverage report from istanbul/JS or if I'm still getting something wrong. Coming from php our file reports tell us how many times each line is executes which is pretty different. For instance, it's obvious that I haven't tested the case of a close() on an open transaction. image I was hoping istanbul would provide something similar. hmmm

dmill-bz commented 8 years ago

Actually I'm pretty sure It's not working right yet. Lets put this on hold

dmill-bz commented 8 years ago

FYI I got this working on gremlin-console with karma and browser tests. So I'll change this PR to include that configuration if you're cool with it.

jbmusso commented 8 years ago

Ah that's cool! Sure, go ahead. Thanks.

dmill-bz commented 8 years ago

Closing this in favor of PR#45