search

jbmusso / gremlin-javascript

JavaScript tools for graph processing in Node.js and the browser inspired by the Apache TinkerPop API
MIT License
214 stars 63 forks source link

Support for SSL and SASL #78

Closed CosmosDB closed 7 years ago

CosmosDB commented 7 years ago

Support for SSL and SASL

Sample usage:

const Gremlin = require("gremlin");

const port = 51549; 
const host = 'localhost';
const client = Gremlin.createClient(port, host, {
    session:false,
    ssl:true,
    user:'user',
 password:'password' } );

The changes contain basic support for gremlin client to connect using SASL protocol to a Gremlin Server that supports authentication (Details on Gremlin SASL specification: http://tinkerpop.apache.org/docs/current/dev/provider/#_authentication).

The changes also contains support for SSL protocol (this is just about switching websockets ws:// to secure websockets wss:// based on an additional option supported by Gremlin.createClient() API)

jbmusso commented 7 years ago

Ah, this is definitely something we need to add. Thanks for sending this, I only see a couple minor issues with your PR so maybe we should start working from there.

jelisejev commented 7 years ago

Hello,

What's the current state of this PR? Did I understand correctly, that the library currently doesn't have any authentication support?