Renamed SASL to sasl according to protocol definition for SASL plain …

jbmusso / gremlin-javascript

JavaScript tools for graph processing in Node.js and the browser inspired by the Apache TinkerPop API

MIT License

214 stars 63 forks source link

Renamed SASL to sasl according to protocol definition for SASL plain … #97

Closed pfilion closed 6 years ago

pfilion commented 6 years ago

Renamed SASL to sasl according to protocol definition for SASL authentication. Now using Buffer object to create the UTF-8 byte encoding

jbmusso commented 6 years ago

Thanks for sending this. I guess we can drop the utf8 dependency altogether then?

jbmusso commented 6 years ago

Thanks, tests are failing since utf8 library is still imported in GremlinClient. Could you please amend your last commit to reflect this change? I think there's a way for me to commit on a fork branch, unsure how. I need to dig in Github doc. Once this passes I'll merge and publish a new version on npm.

pfilion commented 6 years ago

Sure, I have no problem taking care of that ! Voilà !