search

jbn / ZigZag

Python library for identifying the peaks and valleys of a time series.
BSD 3-Clause "New" or "Revised" License
444 stars 178 forks source link

Node to node with the same value #14

Closed MotivaoCrypto closed 2 years ago

MotivaoCrypto commented 2 years ago

There's a mistake in the way the zigzag function applies the peaks and valleys, assigning the same value from one node to the other: image If you see in the last row, it goes from -1 to -1.

mablue commented 2 years ago

Cuz last rows have not an answer in zigzag function cuz of unknown future!zigzag is not for live real algo trading its just usable when you researching on a future known candle

MotivaoCrypto commented 2 years ago

So from -1 to -1 is because it can't find the last peak or valley?

mablue commented 2 years ago

Can yo find the end of earth by walking?!