`formatFiles.excludePattern` doesn't exclude all specified by glob

[snebjorn]

Given this workspace config

"settings": {
  "formatFiles.excludePattern": "**/node_modules/**"
}

I'm seeing this in the log

[14:59:02 info.] (ext) Starting Format Files - Workspace Folder
[14:59:02 info.] (validate-in-workspace) found workspace folders: Backend, Frontend
[14:59:02 info.] (validate-in-workspace) workspace is valid!
[14:59:02 info.] (files-api) searching for files in workspace c:\Users\myuser\my-project
[14:59:02 info.] (files-api)    getting include filter
[14:59:02 warn.] (files-api)    no filters specified
[14:59:02 info.] (files-api)    getting exclude filter
[14:59:02 info.] (files-api)        exclusions glob: {**/node_modules/**}
[14:59:02 info.] (files-api)    filtering by folder: c:\Users\myuser\my-project\frontend
[14:59:02 info.] (files-api)    executing search

[14:59:02 debug] (files-api)            excluded:false  frontend\node_modules\.package-lock.json

[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\ReplaySubject.d.ts
[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\ReplaySubject.js
[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\ReplaySubject.js.map
[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\Rx.d.ts
[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\Rx.js
[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\Rx.js.map
[14:50:29 debug] (files-api)            excluded:false  frontend\node_modules\@angular-devkit\build-angular\node_modules\rxjs\Scheduler.d.ts

[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\about\compodoc\compodoc.component.html
[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\about\compodoc\compodoc.component.ts
[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\about\todomvc\todomvc.component.html
[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\about\todomvc\todomvc.component.ts
[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\shared\components\dumb-component.ts
[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\shared\components\dumb-parent-component.ts
[14:55:38 debug] (files-api)            excluded:false  frontend\node_modules\@compodoc\compodoc\.tmp-compodoc-test-big-app\src\app\shared\components\generic.component.ts

Those paths should be covered by **/node_modules/**

[snebjorn]

node_modules folder is still included using default ignores

[14:14:02 info.] (config) config: {"logLevel":"info","extensionsToInclude":"","excludedFolders":["node_modules",".vscode",".git","dist",".chrome"],"excludePattern":"","inheritWorkspaceExcludedFiles":true,"runOrganizeImports":false,"useGitIgnore":true}
[14:14:02 info.] (config) excluded files: {"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/Thumbs.db":true}

::::::::::::::::::::::::::::::::::::::::::::::::::
[14:14:02 info.] (ext) Starting Format Files - Workspace 
[14:14:02 info.] (validate-in-workspace) found workspace folders: my-project
[14:14:02 info.] (validate-in-workspace) workspace is valid!
[14:14:02 info.] (select-workspace-folder) a single workspace folder was found, selecting my-project
[14:14:02 info.] (files-api) searching for files in workspace path_to/my-project
[14:14:02 info.] (files-api)    getting include filter
[14:14:02 warn.] (files-api)    no filters specified
[14:14:02 info.] (files-api)    getting exclude filter
[14:14:02 info.] (files-api)        including files.exclude globs: **/.git,**/.svn,**/.hg,**/CVS,**/.DS_Store,**/Thumbs.db
[14:14:02 info.] (files-api)        exclusions glob: {**/.git,**/.svn,**/.hg,**/CVS,**/.DS_Store,**/Thumbs.db}
[14:14:02 info.] (files-api)    executing search
path_to\my-project\frontend\node_modules\...
path_to\my-project\frontend\node_modules\...
path_to\my-project\frontend\node_modules\...
path_to\my-project\frontend\node_modules\...
etc...

[tonisives]

Still an issue