search

jboecker / dcs-mission-planner

A browser-based multiplayer mission planner for DCS: World
24 stars 6 forks source link

Update for planner_ng-mapview.js to add annotations for both sides #14

Closed morrtz closed 10 years ago

morrtz commented 10 years ago

New SVG files for \vendors\wikimedia-commons

https://copy.com/yS9QcMvgWolE

jboecker commented 10 years ago

The changes you have made seem to all depend on each other, so they should be in a single commit (and a single pull request). That commit should also include the new SVG files.

We should also implement this feature in a more general way: it should be possible to have a single transparent SVG image for each unit type and set the background color to red or blue with some CSS.

The distinction between MP_ARMOR and MP_AIRDEFENCE also needs to go away. The mission file specifies which unit it is, so the correct symbol should be picked automatically.

The way it is implemented right now is really just a quickly hacked together proof of concept.

morrtz commented 10 years ago

Sorry for the duplicate pulls, this is my first time changing code in Github. You are correct about the changes, as I'm not really a developer, this is the only way I managed to change it.

Also, I suggest giving the admin the ability to pick which units are displayed and which are not for both the red side and blue side. This will be very good when rolling missions which are managed by 2 different sides.

jboecker commented 10 years ago

I am closing these pull requests for now and suggest that we continue to discuss this feature over at issue #4, which I have edited to be a bit more specific.