search

jboesch / jSquares

A simple image gallery with popup information on hover (similar to ted.com)
http://www.boedesign.com/jsquares/
46 stars 17 forks source link

hoverIntent dependency shouldn't be embedded in jSquares code #1

Closed andymantell closed 13 years ago

andymantell commented 13 years ago

At the bottom of the jSquares source, the hoverIntent plugin is included. This shouldn't really be embedded in the code of this plugin. It should just be listed as a dependency in the documentation. The jSquares code should then test whether the hoverIntent plugin is present and fall back to a standard hover if it isn't.

Cheers,

Andy

jboesch commented 13 years ago

Hey Andy,

You're right. I will change this.

jboesch commented 13 years ago

I did not fallback on the hover function as it causes some undesired results, like it opening when it shouldn't and not closing when it should. The same went for when I attempted to just use the $.fn.mouseover method.

I decided it was best to keep the hoverIntent plugin, but it does make sense to move it to a separate file. I am throwing an error if the person forgets to include the file.