search

jbogard / ContosoUniversityCore

MIT License
590 stars 150 forks source link

FXCop warning CA1034 #33

Open gbelzile opened 5 years ago

gbelzile commented 5 years ago

FXCop is not happy with nested public classes. How would you refactor?

jbogard commented 5 years ago

Change the FxCop rules.

On Mon, Jan 7, 2019 at 2:18 PM gbelzile notifications@github.com wrote:

FXCop is not happy with nested public classes. How would you refactor?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jbogard/ContosoUniversityCore/issues/33, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGYMmK87_jgMvnqnloWU0WphyeSln49ks5vA6udgaJpZM4Z0Pwi .

gbelzile commented 5 years ago

Sorry but this is always the wrong/lazy answer. I'll change handlers to internal and create separate classes for requests since they are exposed in the controller. Thanks anyway. I still love most part of this project.

jbogard commented 5 years ago

Ha! Well it's what I would do. It's a bad rule.

Alternative is to use prefixes on class. So instead of Foo.Handler, FooHandler. Or you can use namespaces instead of inner classes.