search

jbogard / MediatR

Simple, unambitious mediator implementation in .NET
Apache License 2.0
11k stars 1.16k forks source link

Remove Auto Registration of Generic Handlers Feature #1060

Open zachpainter77 opened 1 month ago

zachpainter77 commented 1 month ago

This PR completely removes the Auto-Registration of open Generic Request Handlers.

@jbogard I have made this pr so that you can decide what you want to do. Either remove the feature completely or make it Opt-In until we can implement a better resolution strategy.

If this PR is accepted and merged then I will maintain this feature as an extension method in a separate nuget package.

github-actions[bot] commented 1 week ago

This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days.

jbogard commented 6 days ago

I think what I'll do here is keep the tests because they represent the features I'd like to support, but remove the implementation. That it should be able to handle the use cases without any additional configuration. Is it possible to modify the PR to do that?

jbogard commented 6 days ago

And yes the build will fail but that's OK

zachpainter77 commented 5 days ago

Sure I can do that.

On Tue, Sep 3, 2024, 5:43 AM Jimmy Bogard @.***> wrote:

And yes the build will fail but that's OK

— Reply to this email directly, view it on GitHub https://github.com/jbogard/MediatR/pull/1060#issuecomment-2326428708, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL2QUR5BNAIU5JK4BKCYQ3ZUWVF5AVCNFSM6AAAAABL7AQOGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRWGQZDQNZQHA . You are receiving this because you authored the thread.Message ID: @.***>

zachpainter77 commented 14 minutes ago

@jbogard with the completion of pr https://github.com/jbogard/MediatR/pull/1057 do you think it's best to reject this pr and create a new one to remove the functionality but keep the failing tests to allow for development to tackle this in the way you were wanting to?

I feel like it would be easier to just pull in changes from the opt in pr and work from there.

jbogard commented 13 minutes ago

Yeah I think you're right there.