search

jboner / lagom-service-locator-zookeeper

Lagom Service Locator for ZooKeeper
Other
36 stars 24 forks source link

Force java 8 for compilation #2

Closed agibsonccc closed 7 years ago

agibsonccc commented 8 years ago

I'm not sure if this will be relevant for a broader audience, but I've noticed when compiling this in a docker container it was ignoring java home. This will force it to lookup java home from the environment variables when compiling. Maybe you have suggestions that are more suitable for the broader scala audience? Happy to update.

See: http://stackoverflow.com/questions/27461385/invalid-source-release-1-8-on-jenkins-in-sbt

and the reason for SBT upgrade: https://github.com/sbt/sbt/issues/2256

Fabszn commented 8 years ago

Hi,

That's normal that's you change the organization setting?

agibsonccc commented 8 years ago

It wasnt merged. Im just maintaining my own fork at this point. I changed it because I didnt want it to look like it was coming from lightbend