jboner / lagom-service-locator-zookeeper

Lagom Service Locator for ZooKeeper
Other
36 stars 24 forks source link

Locate Kafka brokers #9

Open gladdiologist opened 6 years ago

gladdiologist commented 6 years ago

Hi,

It seems that we can't locate kafka brokers from this implementation. It would be nice to use it, but by default kafka are registered under /brokers and the different path under are not compliant with the way lagom services register themselves.

Example: if we set lagom.broker.kafka.service-name="brokers", we get "Unable to locate Kafka service named [brokers]"

From zookeeper: get /brokers/ids/10001 {"jmx_port":-1,"timestamp":"1516387802916","endpoints":["PLAINTEXT://kafka:9092"],"host":"kafka","version":3,"port":9092}

A Lagom service is exposed as: get /lagom/services/ciscocti/934475431 {"name":"ciscocti","id":"934475431","address":"ciscocti","port":9000,"sslPort":null,"payload":null,"registrationTimeUTC":1516387783366,"serviceType":"DYNAMIC","uriSpec":{"parts":[{"value":"scheme","variable":true},{"value":"://","variable":false},{"value":"serviceAddress","variable":true},{"value":":","variable":false},{"value":"servicePort","variable":true}]}}

I would be glad to get it working as it works when we do a runAll in dev mode, any advice is welcome :) Should we handle this from kafka and its registration method or else?