jbonjean / docker-public-images

Apache License 2.0
5 stars 3 forks source link

ssh for volumio #10

Closed bcdiaconu closed 2 years ago

bcdiaconu commented 3 years ago

It would be nice to have ssh for volumio in order to use remote ssh development environment.

jbonjean commented 3 years ago

Sorry for the delay, I kind of missed this issue. I don't plan to add SSH to the image, but I would gladly accept a PR that adds it if it was optional (environment variables), and disabled by default.

SelfhostedPro commented 3 years ago

You can access the container by using the docker exec command. I don't think ssh is something that would be needed. If you want ssh you could create your own dockerfile and just use something like:

from jbonjean/volumio
apt-get install ssh
expose 22

You'd need to add a line to set a login for the user but I'm unsure of that off the top of my head.

bcdiaconu commented 3 years ago

It is good to have ssh for connecting visual studio code through it and have a full development environment within volumio image. That will enhance debugging experience. Therefore it would be a easy setup, quasi fully working system with powerful debug on both frontend and backend and also on/with shell scripts. And also it would benefit when creating new plugins the same way.

Unfortunately I struggle allot with docker and that's why I requested it here.

SelfhostedPro commented 2 years ago

It is good to have ssh for connecting visual studio code through it and have a full development environment within volumio image. That will enhance debugging experience. Therefore it would be a easy setup, quasi fully working system with powerful debug on both frontend and backend and also on/with shell scripts. And also it would benefit when creating new plugins the same way.

Unfortunately I struggle allot with docker and that's why I requested it here.

Try finding a video on dockerfile basics. This is something that you can do fairly easily for a local copy without the developer needing to push it upon everyone.

You’ll just need to add the few lines above, a configuration for ssh (/etc/sshd/sshd_config) and have a COPY line to put it in the right place.