search

jborean93 / ansible-role-win_openssh

Ansible Role to install Win32-OpenSSH on Windows - https://github.com/PowerShell/Win32-OpenSSH
MIT License
28 stars 17 forks source link

Adding admin local name fix #17

Closed jimbo8098 closed 3 years ago

jimbo8098 commented 3 years ago

There is an issue where the command used at:

https://github.com/jborean93/ansible-role-win_openssh/blob/3ae52fc70c15a38092e7ccbb89ba09b6de3d5afa/tasks/sshd_config.yml#L36-L42

causes the command to be output twice. No idea why because the task doesn't appear to suggest it would, but it does. The fix here was to simply remove the enclosing curly braces. I assume that Ansible no longer requires those curly braces to escape those characters any more and therefore it would be worthwhile to test with earlier versions of Ansible to ensure they are supported (if you intend on supported earlier versions). I am using Ansible 2.11.4.

Fixes https://github.com/jborean93/ansible-role-win_openssh/issues/16

jimbo8098 commented 3 years ago

I'm still working on this by the way! Just building a box for it now in my environment. Will test and look to raise a PR.

jimbo8098 commented 3 years ago

There! Fully tested in my own environment too. 🖤

jborean93 commented 3 years ago

Thanks for sticking with it and fixing the problem!