search

jborean93 / omi

Open Management Infrastructure
Other
111 stars 13 forks source link

Added HTTPS Certificate Verification #8

Closed jborean93 closed 4 years ago

jborean93 commented 4 years ago

Added code that turns on HTTPS certificate verification by default. Still requires some changes to the integration tests to properly try out but a manual test seems to be fine.

This changes the behaviour where cert validation never occurred before. While technically a breaking change I feel that it's for the best to ensure secure connections are actually done with a trusted host. To disable cert verification set the env vars OMI_SKIP_CA_CHECK=1 and OMI_SKIP_CN_CHECK=1.

jborean93 commented 4 years ago

Tests are passing on all the hosts and the docs are present so this is ready for a merge. Just waiting to hear back on https://github.com/PowerShell/PowerShell/issues/13577 to see if there is any interest trying to remove the hardcoded -SkipCACheck -SkipCNCheck requirement in PowerShell. There may be a suggestion in there that might change the approach I take in this PR.

jborean93 commented 4 years ago

After talking it through I don't believe anything mentioned in that issue affects how to implement this. Going to merge this in so that the new functionality is available.