jborean93 / pykrb5

Python krb5 API interface
MIT License
16 stars 7 forks source link

add `krb5.aname_to_localname()` #19

Open pseudometric opened 1 year ago

pseudometric commented 1 year ago
  1. check for errors returned from krb5_init_context()
  2. add glue call to krb5_aname_to_localname()

Thanks for writing this; it looks like it will be quite useful for us!

– Richard Silverman res@arcesium.com

pseudometric commented 1 year ago

I ran your GitHub workflow myself on this; it passes, although there are some unrelated errors on older versions of MacOS that I believe must already be issues you know about.

jborean93 commented 1 year ago

https://github.com/jborean93/pykrb5/pull/20 should work around the macOS testing problem, just push a new commit and hopefully it will pick it up.

pseudometric commented 1 year ago

I reverted the krb5.init_context() fix on this branch, and opened a separate PR for it. It's ready to go and shouldn't wait for me to get time to finish work on the krb5.aname_to_localname() addition.